Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automated deployment to wordpress.org #791

Open
3 tasks
danieliser opened this issue Apr 11, 2020 · 3 comments
Open
3 tasks

Implement automated deployment to wordpress.org #791

danieliser opened this issue Apr 11, 2020 · 3 comments

Comments

@danieliser
Copy link
Member

We can deploy tags off the master branch directly to wordpress.org.

Since we don't merge release/ branches or beta tags into master until they become official releases and are then tagged immediately using git flow, this works perfectly with our setups and allows automating management of readme changes, and assets such as banners can be added directly to the github repo.

Possible Future Enhancements

  • Deployments should build dependencies and run other build routines prior to sending.
@fpcorso
Copy link
Contributor

fpcorso commented Apr 15, 2020

@danieliser Should this be a dependency/sub-issue of #711 or should we remove this part from that issue?

I definitely think we should highly-consider adding this to the scope of 1.11 once we start defining its scope.

@danieliser
Copy link
Member Author

It could be I guess.

@fpcorso fpcorso added this to the v1.12 milestone Jun 5, 2020
@fpcorso fpcorso mentioned this issue Jun 10, 2020
3 tasks
@danieliser
Copy link
Member Author

@fpcorso This should be a good starting point, just too scared to pull the trigger without being able to effectively test the final zip contents before letting them go to wordpress.org.

https://github.com/PopupMaker/Popup-Maker/blob/workflow-deploy-to-wp-org/.github/workflows/deploy-to-wordpress-org.yml

That is will our build processes hold up in the VM and properly include/exclude the right files?

I've been hesitant to merge it for that reason and haven't found a good way to test it. That said we are greatly simplifying our processes by moving to wp-scripts, npm & composer. But still a bit squeemish about just the first run until I know it comes out as a working plugin.

As for readme and asset updates, that could be done now.

@fpcorso fpcorso modified the milestones: v1.12, v1.13 Sep 14, 2020
@fpcorso fpcorso modified the milestones: v1.13, v1.14 Oct 1, 2020
@fpcorso fpcorso modified the milestones: v1.14, v1.15 Nov 5, 2020
@fpcorso fpcorso modified the milestones: v1.15, v1.16 Dec 3, 2020
@fpcorso fpcorso modified the milestones: v1.16, v1.18 Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants