Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Development Tasks #711

Closed
1 of 3 tasks
danieliser opened this issue Nov 26, 2019 · 5 comments
Closed
1 of 3 tasks

Automate Development Tasks #711

danieliser opened this issue Nov 26, 2019 · 5 comments

Comments

@danieliser
Copy link
Member

danieliser commented Nov 26, 2019

The new Github actions system has prompted some new automation potential for us.

This serves as a master list of all possible process automations we can implement for Popup Maker, and eventually the other plugins.

Inspiration: https://10up.com/blog/2019/wordpress-github-actions-streamline-plugin-deployment/

10up Actions: https://github.com/10up/actions-wordpress

@danieliser danieliser changed the title Automate Release Cycles Automate Development Tasks Nov 26, 2019
@fpcorso fpcorso added this to the v1.11 milestone Jan 29, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Jun 5, 2020

@danieliser For the "POT generation" workflow: Do you still want to move that to a workflow as opposed to local build script? If so, should we have that run on pushes to a release/** branch, or can you think of a better event for that one?

@danieliser
Copy link
Member Author

danieliser commented Jun 9, 2020

@fpcorso we may need to see if this is even necessary. For the core plugin I'm pretty confident that wordpress.org

  1. detects a new version tagged.
  2. uses an automated scanner to extract gettext strings from filed directly
  3. Populate GlotPress with the extracted text.
  4. Once translated a langpack is generated and delivered via WP auto updates.

I don't believe that core .pot or .mo files ever are used these days. Likely could look to just remove them and the need for this.

Extensions on the other hand are translated via our own private glotpress install & the trudatore framework. I do believe it mimics wordpress.org in that it pulls directly from out github when there is a new version to populate strings. Once translated it generates langpacks and sends them via auto update.

That said the extension Activator/Updater classes need updating to check our translate.wpopupmaker.com api and hook into the auto updater. Trudatore lib has example code and Ahoy is already set up that way so we can copy from either.

Then we can just forget about pot's & mo's entirely and delete the language folder.

@fpcorso
Copy link
Contributor

fpcorso commented Jun 10, 2020

Moved some of these to their own issues #827 #791 #641

@fpcorso fpcorso modified the milestones: v1.13, v1.14 Sep 17, 2020
@fpcorso fpcorso modified the milestones: v1.14, v1.15 Oct 21, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Dec 2, 2020

@danieliser What did we decide for these last two? Is this still needed or can I close this one?

@danieliser
Copy link
Member Author

@fpcorso The last one would be nice, but its bad practice to not just put , 'popup-maker' explicitly in our gettext calls.

So yea we can scratch those 2 as both WordPress.org and our own glotpress installs pull directly from the code base.

@fpcorso fpcorso closed this as completed Dec 3, 2020
@fpcorso fpcorso removed this from the v1.15 milestone Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants