-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph to parquet #1932
Graph to parquet #1932
Conversation
8af2de9
to
6d229b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to clarify
raphtory/src/algorithms/motifs/local_temporal_three_node_motifs.rs
Outdated
Show resolved
Hide resolved
b7b79b0
to
3f53187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: 588866f | Previous: b355d45 | Ratio |
---|---|---|---|
lotr_graph_subgraph_10pc_windowed/iterate edges |
15351 ns/iter (± 109 ) |
7482 ns/iter (± 25 ) |
2.05 |
This comment was automatically generated by workflow using github-action-benchmark.
seems to have been random variation, not reproduced in later commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Write the Graph to parquet
Why are the changes needed?
#1908
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Unit and Proptests
Are there any further changes required?
Yes