Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph to parquet #1932

Merged
merged 10 commits into from
Jan 30, 2025
Merged

Graph to parquet #1932

merged 10 commits into from
Jan 30, 2025

Conversation

fabianmurariu
Copy link
Collaborator

What changes were proposed in this pull request?

Write the Graph to parquet

Why are the changes needed?

#1908

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

Unit and Proptests

Are there any further changes required?

Yes

@fabianmurariu fabianmurariu force-pushed the graph_to_parquet branch 3 times, most recently from 8af2de9 to 6d229b1 Compare January 24, 2025 17:50
Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to clarify

raphtory/src/algorithms/pathing/dijkstra.rs Outdated Show resolved Hide resolved
raphtory/src/core/mod.rs Show resolved Hide resolved
raphtory/src/core/mod.rs Show resolved Hide resolved
raphtory/src/core/mod.rs Show resolved Hide resolved
raphtory/src/io/parquet_loaders.rs Outdated Show resolved Hide resolved
raphtory/src/io/parquet_loaders.rs Outdated Show resolved Hide resolved
raphtory/src/io/parquet_loaders.rs Outdated Show resolved Hide resolved
raphtory/src/io/parquet_loaders.rs Outdated Show resolved Hide resolved
raphtory/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 588866f Previous: b355d45 Ratio
lotr_graph_subgraph_10pc_windowed/iterate edges 15351 ns/iter (± 109) 7482 ns/iter (± 25) 2.05

This comment was automatically generated by workflow using github-action-benchmark.

@ljeub-pometry
Copy link
Collaborator

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'. Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 588866f Previous: b355d45 Ratio
lotr_graph_subgraph_10pc_windowed/iterate edges 15351 ns/iter (± 109) 7482 ns/iter (± 25) 2.05
This comment was automatically generated by workflow using github-action-benchmark.

seems to have been random variation, not reproduced in later commits

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianmurariu fabianmurariu merged commit 0a9ba26 into master Jan 30, 2025
19 checks passed
@fabianmurariu fabianmurariu deleted the graph_to_parquet branch January 30, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants