replace AlgorithmResult with NodeState in rust #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
feature/ReplaceAlgorithmResult
branch
2 times, most recently
from
2dd6dd5 to
facd73f
Compare
ljeub-pometry
force-pushed
the
feature/ReplaceAlgorithmResult
branch
from
386c9fd to
505bc5f
Compare
ljeub-pometry
requested review from
fabianmurariu,
wyatt-joyner-pometry and
miratepuffin
and removed request for
fabianmurariu and
wyatt-joyner-pometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Interface and efficiency improvements
Does this PR introduce any user-facing change? If yes is this documented?
Yes, the NodeState apis are somewhat different (and hopefully better) than the AlgorithmResult. All methods have documentation and the return type for all the algorithms is annotated in python.
How was this patch tested?
Updated tests for the new apis.
Are there any further changes required?