Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMake, Fixed Memory Leak, Fixed Score #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheMrPoseidon
Copy link

In order to work properly on mac I've changed the build system to cmake. Additionally, I've fixed two minor problems a) memory leak in WindowsRenderer that increase the memeroy usage over time and b) fixed the output of distance and best values.

@mandar1jn
Copy link

@TheMrPoseidon why did you change SDL2/sdl to just sdl? I think the first one is used in case sdl(1) is also installed

@TheMrPoseidon
Copy link
Author

@TheMrPoseidon why did you change SDL2/sdl to just sdl? I think the first one is used in case sdl(1) is also installed

I'm not a pro in how cross plattform development should be done with sdl2, but as far as I know on unix system (linux and mac) you should use sdl2/sdl.h, but for windows and as for emscripten if I remember correctly you should use the include without the namespace upfront. Hope this answers your question, if not I'm happy to test my code (It's been a while) and come back to you.

@TheMrPoseidon
Copy link
Author

@mandar1jn Forget what I said, the change from #include <SDL2/SDL.h> to #include <SDL.h> was done to work with the SDL2 cmake scripts.

@TheMrPoseidon TheMrPoseidon deleted the branch PolyMarsDev:master December 26, 2021 16:00
@TheMrPoseidon TheMrPoseidon deleted the master branch December 26, 2021 16:00
@TheMrPoseidon TheMrPoseidon restored the master branch December 26, 2021 16:03
@TheMrPoseidon TheMrPoseidon reopened this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants