Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update pygit2 requirement from <1.6.0,>=1.2.1 to >=1.2.1,<1.8.0 #446

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2021

Updates the requirements on pygit2 to permit the latest version.

Changelog

Sourced from pygit2's changelog.

1.7.0 (2021-10-08)

  • Upgrade to libgit2 1.3.0 [#1089](https://github.com/libgit2/pygit2/issues/1089) <https://github.com/libgit2/pygit2/pull/1089>_

  • Linux wheels now bundled with libssh2 1.10.0 (instead of 1.9.0)

  • macOS wheels now include libssh2

  • Add support for Python 3.10 [#1092](https://github.com/libgit2/pygit2/issues/1092) <https://github.com/libgit2/pygit2/pull/1092>_ [#1093](https://github.com/libgit2/pygit2/issues/1093) <https://github.com/libgit2/pygit2/pull/1093>_

  • Drop support for Python 3.6

  • New pygit2.GIT_CHECKOUT_SKIP_LOCKED_DIRECTORIES [#1087](https://github.com/libgit2/pygit2/issues/1087) <https://github.com/libgit2/pygit2/pull/1087>_

  • New optional argument location in Repository.applies(..) and Repository.apply(..) [#1091](https://github.com/libgit2/pygit2/issues/1091) <https://github.com/libgit2/pygit2/pull/1091>_

  • Fix: Now the flags argument in Repository.blame() is passed through [#1083](https://github.com/libgit2/pygit2/issues/1083) <https://github.com/libgit2/pygit2/pull/1083>_

  • CI: Stop using Travis, move to GitHub actions

Caveats:

  • Windows wheels for Python 3.10 not yet available.

1.6.1 (2021-06-19)

  • Fix a number of reference leaks
  • Review custom object backends

Breaking changes:

  • In custom backends the callbacks have been renamed from read to read_cb, write to write_cb, and so on.

1.6.0 (2021-06-01)

  • New optional proxy argument in Remote methods [#642](https://github.com/libgit2/pygit2/issues/642) <https://github.com/libgit2/pygit2/issues/642>_

... (truncated)

Commits
  • f93efd8 Release 1.7.0
  • de4eac1 Drop support for Python 3.6
  • 8f11a72 Fixing download libssh2 in CI
  • 8b25be3 Fixing Python 3.10 wheels for macos
  • 3039611 fetch wheel from macos11.pkg for Python3.10
  • bebe0ac Add support for Python3.10 (#1092)
  • 8d3403c CI pass tests
  • df8c204 Update to libgit2 1.3.0
  • e1005de Merge remote-tracking branch 'jorio/apply-location'
  • 5aed494 Add location argument to Repository.apply/applies
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [pygit2](https://github.com/libgit2/pygit2) to permit the latest version.
- [Release notes](https://github.com/libgit2/pygit2/releases)
- [Changelog](https://github.com/libgit2/pygit2/blob/master/CHANGELOG.rst)
- [Commits](libgit2/pygit2@v1.2.1...v1.7.0)

---
updated-dependencies:
- dependency-name: pygit2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@vulder
Copy link
Collaborator

vulder commented Jan 2, 2022

@simbuerg Do you have an idea why a newer pygit2 version breaks the container tests?

@boehmseb
Copy link
Collaborator

boehmseb commented Jan 5, 2022

Would be good to know indeed. We desperately need to upgrade to pygit2 1.7 with the tool-suite, both, for features (my whitespace fix) and for the python 10 support.

@boehmseb
Copy link
Collaborator

boehmseb commented Jan 5, 2022

I'm not yet sure why it fails now but any reruns will fail because alpine:edge now ships python 10 which requires this PR so benchbuild can be installed 😅

@boehmseb
Copy link
Collaborator

boehmseb commented Jan 5, 2022

After manually resolving mentioned problem with the alpine version I could not reproduce this issue. The integration tests pass on my machine.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #446 (f67fdde) into master (f3f8343) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   50.93%   50.92%   -0.01%     
==========================================
  Files         123      123              
  Lines        7716     7717       +1     
  Branches     1042     1206     +164     
==========================================
  Hits         3930     3930              
- Misses       3632     3633       +1     
  Partials      154      154              
Impacted Files Coverage Δ
benchbuild/utils/user_interface.py 47.05% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f62411...f67fdde. Read the comment docs.

Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it seems to work also in the CI, not sure what the issue was 😆

@boehmseb
Copy link
Collaborator

boehmseb commented Jan 5, 2022

Now I'm confused. This should fail for the reasons I described above. And if you look at the logs, the integration test that builds the container (and subsequent tests) does indeed fail. It just seems that the error handling is good enough so that benchbuild doesn't die so the CI does not detect the fail 🙈

@vulder
Copy link
Collaborator

vulder commented Jan 5, 2022

Hmm, maybe they reverted the python3.10 change? Or Fixed something else in alpine.
@simbuerg maybe we should add an unit/integrationtest run for python3.10, just to be sure?

@boehmseb
Copy link
Collaborator

boehmseb commented Jan 5, 2022

No, the test does fail, the fail just isn't picked up by the CI because benchbuild does not crash.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 6, 2022

A newer version of pygit2 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@simbuerg simbuerg merged commit 0951f1e into master Jan 11, 2022
@dependabot dependabot bot deleted the dependabot/pip/pygit2-gte-1.2.1-and-lt-1.8.0 branch January 11, 2022 23:58
@simbuerg
Copy link
Member

Merged this, but a follow-up PR has to fix #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants