-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update pygit2 requirement from <1.6.0,>=1.2.1 to >=1.2.1,<1.8.0 #446
build(deps): update pygit2 requirement from <1.6.0,>=1.2.1 to >=1.2.1,<1.8.0 #446
Conversation
Updates the requirements on [pygit2](https://github.com/libgit2/pygit2) to permit the latest version. - [Release notes](https://github.com/libgit2/pygit2/releases) - [Changelog](https://github.com/libgit2/pygit2/blob/master/CHANGELOG.rst) - [Commits](libgit2/pygit2@v1.2.1...v1.7.0) --- updated-dependencies: - dependency-name: pygit2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
@simbuerg Do you have an idea why a newer pygit2 version breaks the container tests? |
Would be good to know indeed. We desperately need to upgrade to pygit2 1.7 with the tool-suite, both, for features (my whitespace fix) and for the python 10 support. |
I'm not yet sure why it fails now but any reruns will fail because |
After manually resolving mentioned problem with the alpine version I could not reproduce this issue. The integration tests pass on my machine. |
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 50.93% 50.92% -0.01%
==========================================
Files 123 123
Lines 7716 7717 +1
Branches 1042 1206 +164
==========================================
Hits 3930 3930
- Misses 3632 3633 +1
Partials 154 154
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it seems to work also in the CI, not sure what the issue was 😆
Now I'm confused. This should fail for the reasons I described above. And if you look at the logs, the integration test that builds the container (and subsequent tests) does indeed fail. It just seems that the error handling is good enough so that benchbuild doesn't die so the CI does not detect the fail 🙈 |
Hmm, maybe they reverted the python3.10 change? Or Fixed something else in alpine. |
No, the test does fail, the fail just isn't picked up by the CI because benchbuild does not crash. |
A newer version of pygit2 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Merged this, but a follow-up PR has to fix #468 |
Updates the requirements on pygit2 to permit the latest version.
Changelog
Sourced from pygit2's changelog.
... (truncated)
Commits
f93efd8
Release 1.7.0de4eac1
Drop support for Python 3.68f11a72
Fixing download libssh2 in CI8b25be3
Fixing Python 3.10 wheels for macos3039611
fetch wheel from macos11.pkg for Python3.10bebe0ac
Add support for Python3.10 (#1092)8d3403c
CI pass testsdf8c204
Update to libgit2 1.3.0e1005de
Merge remote-tracking branch 'jorio/apply-location'5aed494
Add location argument to Repository.apply/appliesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)