-
Notifications
You must be signed in to change notification settings - Fork 197
Massachusetts Child Care Financial Assistance (CCFA) #6390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The failing test is due to SSI formula changed |
policyengine_us/variables/gov/states/ma/eec/ccfa/eligibility/ma_ccfa_activity_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/eec/ccfa/eligibility/ma_ccfa_immigration_eligible.py
Outdated
Show resolved
Hide resolved
...cyengine_us/parameters/gov/states/ma/eec/ccfa/income/income_limits/redetermination_rate.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/eec/ccfa/eligibility/ma_ccfa_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/eec/ccfa/copay/ma_ccfa_base_copay.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ma/eec/ccfa/qualified_immigration_statuses.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ma/eec/ccfa/region/metro_and_boston_metro.yaml
Show resolved
Hide resolved
...s/parameters/gov/states/ma/eec/ccfa/reimbursement_rates/family_child_care/age_threshold.yaml
Show resolved
Hide resolved
...s/gov/states/ma/eec/ccfa/reimbursement/ma_ccfa_center_based_early_education_reimbursement.py
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6390 +/- ##
===========================================
+ Coverage 72.98% 99.55% +26.57%
===========================================
Files 3129 30 -3099
Lines 44951 453 -44498
Branches 229 1 -228
===========================================
- Hits 32806 451 -32355
+ Misses 12131 1 -12130
+ Partials 14 1 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question but LGTM
policyengine_us/variables/gov/states/ma/eec/ccfa/ma_ccfa_child_age_category.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/eec/ccfa/ma_ccfa_child_age_category.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about refactoring to make a ma_ccfa_uncapped_daily_payment
variable which uses a select
statement, since the rest of it (* attending_days_per_month * reimbursement_multiplier
) is the same across the provider types?
Fixes #6381