Skip to content

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Aug 12, 2025

Fixes #6381

@hua7450 hua7450 marked this pull request as ready for review August 21, 2025 18:47
@hua7450
Copy link
Collaborator Author

hua7450 commented Aug 21, 2025

The failing test is due to SSI formula changed

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 99.54649% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.55%. Comparing base (f82c3ad) to head (6bca5d1).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...us/variables/gov/states/ma/eec/ccfa/ma_ccfa_fpg.py 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6390       +/-   ##
===========================================
+ Coverage   72.98%   99.55%   +26.57%     
===========================================
  Files        3129       30     -3099     
  Lines       44951      453    -44498     
  Branches      229        1      -228     
===========================================
- Hits        32806      451    -32355     
+ Misses      12131        1    -12130     
+ Partials       14        1       -13     
Flag Coverage Δ
unittests 99.55% <99.54%> (+26.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hua7450 hua7450 marked this pull request as draft September 8, 2025 16:26
@hua7450 hua7450 marked this pull request as ready for review September 9, 2025 06:21
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question but LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about refactoring to make a ma_ccfa_uncapped_daily_payment variable which uses a select statement, since the rest of it (* attending_days_per_month * reimbursement_multiplier) is the same across the provider types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Massachusetts Child Care Financial Assistance (CCFA)
3 participants