Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building arm6/7 docker image and reduce Docker image size #1177

Merged
merged 14 commits into from
Jan 6, 2025
Merged

Conversation

Naramsim
Copy link
Member

@Naramsim Naramsim commented Dec 20, 2024

  • Better pin docker base images
  • Use two stage Docker build, added binutils installations in the builder phase that solved being unable to build the image on arm6 and arm7.
  • Remove some deprecations
  • Bump some patch versions
  • Remove some unused dependencies

@Naramsim Naramsim changed the title Upgrade patches requirements.txt Fix building arm6/7 docker image and reduce Docker image size Dec 21, 2024
@Naramsim Naramsim requested a review from a team December 21, 2024 16:18
Copy link
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of Docker stuff is beyond my comprehension but I trust you 🤝

@Naramsim Naramsim merged commit c49b5bb into master Jan 6, 2025
4 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants