-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: New translations #752
base: main
Are you sure you want to change the base?
Conversation
0c028e1
to
c29c336
Compare
We usually do that only once before each release, but I can merge it if you want. Maybe our translation workflow is not ideal? And we should probably document it better… |
I don't know how Crowdin works, will merging it and sending translations through Circle CI delete al pending translations ? |
c29c336
to
9be5804
Compare
I don't really now how Crowdin works when you do that either… |
Hi, @floreal
No, they won't delete any pending translations.
@elegaanz said the reason why they merge translations just before new release:
How do you think about this? In an aside, you can download pending translations from Crowdin once you create an account.
After that, you can replace po files with it and check translations on local app although it takes some time. |
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 39.02% 39.01% -0.01%
==========================================
Files 73 73
Lines 9699 9701 +2
Branches 2224 2224
==========================================
Hits 3785 3785
- Misses 4863 4865 +2
Partials 1051 1051 |
When building, new translations appear. This PR is here just to update translation files and update translations on crowdin.