Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: New translations #752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

floreal
Copy link
Contributor

@floreal floreal commented Apr 18, 2020

When building, new translations appear. This PR is here just to update translation files and update translations on crowdin.

@floreal floreal changed the title Added: New translationss Added: New translations Apr 18, 2020
@floreal floreal force-pushed the translations-update branch from 0c028e1 to c29c336 Compare April 18, 2020 13:20
@elegaanz
Copy link
Member

We usually do that only once before each release, but I can merge it if you want. Maybe our translation workflow is not ideal? And we should probably document it better…

@floreal
Copy link
Contributor Author

floreal commented Apr 19, 2020

I don't know how Crowdin works, will merging it and sending translations through Circle CI delete al pending translations ?
If not, I think it's a good idea to send them before a release is made so that this could buy some time to translators to work before releases are made.
How other projects do that ?

@floreal floreal force-pushed the translations-update branch from c29c336 to 9be5804 Compare April 19, 2020 11:41
@elegaanz
Copy link
Member

I don't really now how Crowdin works when you do that either…

@KitaitiMakoto
Copy link
Contributor

KitaitiMakoto commented Apr 30, 2020

Hi, @floreal

will merging it and sending translations through Circle CI delete al pending translations ?

No, they won't delete any pending translations.

If not, I think it's a good idea to send them before a release is made so that this could buy some time to translators to work before releases are made.

@elegaanz said the reason why they merge translations just before new release:

We usually pull translations just before publishing a release, to avoid polluting the git history with repetitive commits.

How do you think about this?

In an aside, you can download pending translations from Crowdin once you create an account.

  1. Visit project page
  2. Select your language
  3. Open menu alongside file name: Screenshot from Gyazo
  4. Tap "Download" link

After that, you can replace po files with it and check translations on local app although it takes some time.

@elegaanz elegaanz changed the base branch from master to main July 5, 2020 16:19
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #752 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   39.02%   39.01%   -0.01%     
==========================================
  Files          73       73              
  Lines        9699     9701       +2     
  Branches     2224     2224              
==========================================
  Hits         3785     3785              
- Misses       4863     4865       +2     
  Partials     1051     1051              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants