Add offline policy evaluation module and update dependencies #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
from
41a0a84
to
b8ea4dd
Compare
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
from
b8ea4dd
to
cb05e5a
Compare
j3rom3c
reviewed
Sep 10, 2024
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
14 times, most recently
from
b117ef0
to
d5118c3
Compare
|
Mainly general comments, since I am using the library for a project:
|
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
2 times, most recently
from
2ba33e1
to
d4d0dfc
Compare
@j3rom3c, note that: |
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
5 times, most recently
from
0d618da
to
703e25a
Compare
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
17 times, most recently
from
97e8e51
to
c2d073f
Compare
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
11 times, most recently
from
92e979a
to
2f136be
Compare
### Changes * Introduced `offline_policy_evaluator.py` with classes for propensity score estimation and offline policy evaluation. * Introduced `offline_policy_estimator.py` with classes for offline policy estimation. * Updated `pyproject.toml` to include new dependencies: `bokeh` and `optuna`. Further adjusted existing dependencies to compatible versions and added python 3.12 support. * Changed .pre-commit-config.yaml to utilize nbstripout instead of nbdev_clean. * Added caching of dependencies on CI and CD. * Added class method to PyBanditsBaseModel on base.py to allow seeing default values for arguments that were not passed to the model. * Added test_offline_policy_evaluator.py and test_offline_policy_estimator.py as a test suite for the OfflinePolicyEvaluator. * Added `get_non_abstract_classes` and `visualize_via_bokeh` utility functions.
shaharbar1
force-pushed
the
feature/offline_policy_evaluation
branch
from
2f136be
to
74da683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
offline_policy_evaluator.pywith classes for propensity score estimation and offline policy evaluation.offline_policy_estimator.pywith classes for offline policy estimation.pyproject.tomlto include new dependencies:bokehandoptuna. Further adjusted existing dependencies to compatible versions and added python 3.12 support.get_non_abstract_classes,visualize_via_bokehandin_jupyter_notebookutility functions.