test: Native Render #1059
Draft
test: Native Render #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged initialize options.
…stead of pointers to values - and update the test suite to test not just eos sdk initialize options but also platform create options.
paulhazen
added
enhancement
paulhazen
requested review from
WispyMouse,
arthur740212 and
andrew-hirata-playeveryware
paulhazen
changed the base branch from
development
to
fix/native-use-new-config
… added clarifying comments to the tests.
WispyMouse
reviewed
Dec 16, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
WispyMouse
reviewed
Dec 16, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/ManagedPluginCode/Application.cs
Show resolved
Hide resolved
WispyMouse
approved these changes
Dec 16, 2024
The solution only requires the tests to compile if in
It's standard practice to put test projects in the same solution as the projects that they are designed to test.
That dependency is only for |
arthur740212
approved these changes
Dec 18, 2024
andrew-hirata-playeveryware
requested changes
Dec 18, 2024
paulhazen
changed the base branch from
fix/native-use-new-config
to
development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds unit tests that confirm the equivalency of config values as read from the native and managed components of the plugin.
Important
This PR has been moved to draft pending an internal discussion regarding the best testing framework to utilize.
#EOS-1982