forked from cornerstonejs/cornerstone3D
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Colormap Opacity #2
Open
Sofien-Sellami
wants to merge
15
commits into
main
Choose a base branch
from
colormaps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e set of colormap
…e set of colormap
resync main
salimkanoun
pushed a commit
that referenced
this pull request
Dec 14, 2024
* feat: dynamic threshold sphere * Add dynamic sphere * fix: Performance issues on threshold sphere * performance * feat: Create segmentation voxel manager in initial create of volume * Faster fill for fixing features * performance: Fix the performance of island removal * fix restore of mixed islands * fix external island removal on non-acquisition * Performance and planar filling improvements * Fix flood fill not being planar * Remove invalid points in shape * feat: Add a labelmap statistics calculator (#2) * fix: Change to names for statistics so that other implementations can be added * Fix build issues * feat: Add working statistics calcs * fix: Add stats to the labelmap calculator * Compute labelmap statistics and lesion glycolysis * PR comments * PR comments * PR - comments added * PR review comments * PR fixes - mostly cleanup * Improvements to threshold out of plane * Missed a fix on the sphere change * fix * fix * fix * wip * api * fix: RLE rendering for segmentations * fix: Undefined error on reject preview * wip * wip * refactoring * fix * Enhance VoxelManager and RenderingEngine: - Updated `getMinMax` method in `VoxelManager` to handle array inputs for min/max calculations. - Modified `setDefaultVolumeVOI` to correctly compute min/max values from voxel data. - Cleaned up and restructured tests in `volumeViewport_gpu_render_test.js`, restoring necessary imports and ensuring proper rendering tests for various volume types. * update * bring back tests * update ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment