New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repeat value placement for zone cleaning payload in valetudo template #772

Open

globalnamespace wants to merge 1 commit into PiotrMachowski:master from globalnamespace:patch-1

globalnamespace commented Nov 9, 2024

For zone cleaning, the valetudo template has the number of repeats inside each object in the "zones" array.

{
  "zones": [
    {
      "points": {
        "pA": {
          "x": 3246,
          "y": 2632
        },
        "pB": {
          "x": 3546,
          "y": 2632
        },
        "pC": {
          "x": 3546,
          "y": 2833
        },
        "pD": {
          "x": 3246,
          "y": 2833
        }
      },
      "iterations": 3
    }
  ]
}

But this is incorrect. Valetudo expects the number of repeats to be outside of the "zones" array.

{
  "zones": [
    {
      "points": {
        "pA": {
          "x": 3246,
          "y": 2632
        },
        "pB": {
          "x": 3546,
          "y": 2632
        },
        "pC": {
          "x": 3546,
          "y": 2833
        },
        "pD": {
          "x": 3246,
          "y": 2833
        }
      }
    }
  ],
  "iterations": 3
}

I've updated the template to put the number of repeats in the correct place.

I tested this by overriding the payload in the config for the map card and now my vacuum correctly does the specified number of repeats.


          Fix repeat value placement for zone cleaning payload in valetudo temp…

92f38b2

…late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet