Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable plugin management via the admin interface #1

Merged
merged 4 commits into from
May 24, 2024

Conversation

jakecoble
Copy link
Collaborator

This also replaces the docker-compose.yml with a shell script out of necessity.

This does not inform the user about why the feature isn't working or what to do about it. That's waiting for a resolution on ether/etherpad-lite#6390

@jakecoble jakecoble requested a review from narthur May 22, 2024 19:35
Copy link
Collaborator

@narthur narthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@narthur
Copy link
Collaborator

narthur commented May 24, 2024

Question--I see that docker-up.sh spins up both etherpad and postgres for local dev. How are you planning to spin up etherpad when it's running in its own server, separate from the postgres server?

@narthur
Copy link
Collaborator

narthur commented May 24, 2024

Also what do you think of moving docker-up.sh and docker-down.sh to the scripts dir to keep all the shell scripts together? 🤔

@jakecoble
Copy link
Collaborator Author

I'll split the postgres server into something like docker-up.dev.sh

I can see the argument for moving the scripts into the scripts directory, but I also think it makes sense to have "project level" scripts in the project root and "data level" scripts in the scripts directory. Similar how you you might not include "eslint.config.js" or similar in a src/ directory since it's part of defining the project. I don't feel strongly either way.

@narthur narthur merged commit eec8f01 into main May 24, 2024
4 checks passed
@narthur narthur deleted the disable-admin-plugins branch May 24, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants