Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ImGui shaders reflection in GLSL #123

Open
Pikachuxxxx opened this issue Apr 10, 2022 · 1 comment
Open

Improve ImGui shaders reflection in GLSL #123

Pikachuxxxx opened this issue Apr 10, 2022 · 1 comment
Labels
enhancement New feature or request Shaders Issues related to Shaders(GLSL, HLSL etc)

Comments

@Pikachuxxxx
Copy link
Owner

Pikachuxxxx commented Apr 10, 2022 •
edited
Loading

imGui shaders reflection using SPIRV-Reflect in glsl produces wrong stride of 32 because the color is supplied as U32 but we have vec4 on the glsl side and it returns a format R32G32B32A32_UNORM instead of `R8G8B8A8_UNORM.
@Pikachuxxxx Pikachuxxxx added enhancement New feature or request good first issue Good for newcomers Shaders Issues related to Shaders(GLSL, HLSL etc) labels Apr 10, 2022
@Pikachuxxxx
Copy link
Owner Author

Workaround : currently we check for the shader name and this is hardcoded(stride and format). A general solution must be designed for this

@Pikachuxxxx Pikachuxxxx removed the good first issue Good for newcomers label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Shaders Issues related to Shaders(GLSL, HLSL etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pikachuxxxx