Introduce FluxMapNotNull{,Transformation}OrElse Refaster rules
#1493
Conversation
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
werli/more-flux-map-null
branch
from
5821073 to
5cfb7ca
Compare
There was a problem hiding this comment.
Nice one @werli! I rebased and added a commit. Suggested commit message:
Introduce `FluxMapNotNull{,Transformation}OrElse` Refaster rules (#1493)
|
|
||
| @BeforeTemplate | ||
| Flux<S> before(Flux<T> flux) { | ||
| return flux.map(x -> transformation(x)).mapNotNull(x -> x.orElse(null)); |
There was a problem hiding this comment.
It turns out that the test for this rule currently fails because x is reused. Official Java scoping rules have these variables be independent, but I suspect that Refaster takes a shortcut somewhere. Good that we have tests :)
| @@ -889,6 +889,35 @@ Flux<S> after(Flux<T> flux) { | |||
| } | |||
| } | |||
|
|
|||
| /** Prefer {@link Flux#mapNotNull(Function)} over more contrived alternatives. */ | |||
There was a problem hiding this comment.
Both variants use mapNotNull; will propose something.
| @@ -889,6 +889,35 @@ Flux<S> after(Flux<T> flux) { | |||
| } | |||
| } | |||
|
|
|||
| /** Prefer {@link Flux#mapNotNull(Function)} over more contrived alternatives. */ | |||
| abstract static class FluxMapNotNullMapOptional<T, S> { | |||
There was a problem hiding this comment.
We're still figuring out our preferred naming strategy, but tentatively it'd be something like FluxMapNotNullOrElse. Since the rule below would yield the same name, perhaps we'd go for FluxMapNotNullTransformationOrElse here 🤔. Will use that for now.
Stephan202
changed the title
FluxMapNotNull(Map)Optional Refaster rulesFluxMapNotNull{,Transformation}OrElse Refaster rules
|
Looks good. No mutations were possible for these changes. |
|
|
As @Stephan202 was already reviewing and I don't see any open points; I dropped the |
|
Thanks @Stephan202 & @rickie - LGTM 👍 |
I want to advocate for using
Flux#mapNotNullmore, even if that includes defaulting to an explicitnullvalue.I'm happy to learn how to fuse those into one rule. 👀
Suggested commit message: