Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simple fix] InitialPayload was invalid in TeamClass #1375

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

a851903106
Copy link

@a851903106 a851903106 commented Sep 6, 2024

This is a very simple fix to help TechnoClasses created via a trigger operation get the InitialPayload correctly.

If the Ares.dll in use is 3.0 or 3.0p1, it will call the function from Ares itself, otherwise it will use another function.

Thanks to @NetsuNegi and @ststl-s for helping when I was in a bind.

PS: It will only trigger if the carrier has no passengers.

@NetsuNegi
Copy link
Contributor

It should be clear for now :)

@chaserli
Copy link
Contributor

If I understand it correctly, this aims to do the exact same thing as #1283 .
And I've yet which part in your impl prevented deadlock.
In fact, I would like to know why the mutex was used for creation (8279392)
If you have an answer to that or to how to reproduce the deadlock in case the mutex handling is removed, I would love to learn about that.
Nevertheless #1283 no longer touches the mutex and is idempotent, theoretically no deadlock.

@MortonPL MortonPL added Interaction Something related to interaction with other extension, program etc. Fixed / Improved Logic Minor stuff Needs testing Maybe unnecessary labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed / Improved Logic Minor stuff Interaction Something related to interaction with other extension, program etc. Maybe unnecessary Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants