Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Reflect Damage Tweak #1354

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Aug 13, 2024

added a few more tags to further customize ReflectDamage

  • ReflectDamage.Chance determines the chance of reflection.
  • ReflectDamage.Override directly overrides the damage.
  • SuppressReflectDamage.Groups does the same thing as SuppressReflectDamage.Types but for all AttachEffectTypes in the listed groups.

In rulesmd.ini:

[SOMEATTACHEFFECT]                             ; AttachEffectType
ReflectDamage.Chance=1.0                       ; floating point value
ReflectDamage.Override=                        ; integer

[SOMEWARHEAD]
SuppressReflectDamage.Groups=                  ; comma-separated list of strings (group IDs)

@github-actions github-actions bot added the Minor Documentation is not required label Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Starkku Starkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, little bit unsure about clarity of ReflectDamage.Override as a key name but I can't think of a suitable replacement currently. There's one small thing I'd change though.

src/Ext/WarheadType/Body.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants