fix Steam stop function, it can get into an infinite loop #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional details after some more testing. On the Steam Deck, one of the process that it will try to stop is "steamos-manager", which is owned by root, so it will never be able to break the loop. Other option would be looking for exact names in the process lookup, although I'm not sure if it's not intentionally used because of platforms such as flatpak. |
Ont the Steam Deck, it will try to kill the steamos-manager process, which is owned by root.
davidmartos96
force-pushed
the
fix_restarter
branch
from
8ad6475 to
8e40ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a recent update I encountered that the "wait for Steam to close" function was getting stuck.
The problem seems to be the change in the
whileloop exit condition in 10caa7bWe can additionally check if the process is still alive.
What do you think?