-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prb v3.2 #1580
Merged
Merged
prb v3.2 #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. processor: when use standalone sync, should not broadcast 2. sync headers db to newest in beginning 3. tempoarily disable full verify headers db since it's too slow
1. if no fast sync, para_headernum=0 does not mean next para_header is 0 2. if get_info got un-match status, MarkError 3. if fail to generate sync request, log; if more than 3 times, show on UI
1. update prb UI every time after update session info 2. correct block numbers on UI
Great! |
In some case, get_sync_request maybe faster than the chaintip info in processor. After such sync, the workers may have newer block than processor know. They should also be considered as "reached_chaintip", and pending for broadcast. Also, when processor received an empty request, and found that the worker is "reached_chaintip", when it stops to request next sync, it should also mark the worker pending for broadcast.
1. delete from UI after deleting a worker 2. restart after changing sync-only flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.