External sources of (league) score data #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is potentially useful when importing league data from another round of leagues which we don't want to represent within a compstate, or when awarding league points for activities which are not actually league matches.
This is potentially useful when importing league data from another round of leagues which we don't want to represent within a compstate, or when awarding league points for activities which are not actually league matches.
PeterJCLaw
force-pushed
the
external-score-sources
branch
from
ea7b83c to
2dc9ff1
Compare
prophile
approved these changes
Feb 5, 2023
|
|
||
| team: str | ||
| game_points: NotRequired[int] | ||
| league_points: int |
There was a problem hiding this comment.
We could start thinking about something like pydantic for validating these data as we read them in based on the types, though that's out of scope here.
There was a problem hiding this comment.
Yeah, I've been wondering about having some schema stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a mechanism for additional league points (and league-section game points) to be assigned to teams at the competition. The source of these points is deliberately out of scope, allowing complete freedom for judges to merge in other sources of data.
Specifically: a new top level directory
externalmay now exist, if it does then it should contain*.yamlfiles with content like:No restriction is made on the number of times the data for a team may appear in a given file, nor between files.
Fixes srobo/tasks#973
This doesn't directly address #17, however may provide a way to achieve a similar outcome.
See also PeterJCLaw/dummy-comp#1 for example data.