t/porting/podcheck.t don't open Win32 MSVC related compiler binary files #22684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t/porting/podcheck.t
Outdated
Comment on lines
435
to
436
| | obj # Windows, ignore MSVC even for GCC | ||
| | pch # Windows, ignore MSVC even for GCC |
There was a problem hiding this comment.
This PR basically LGTM, but the latter two comments might be more informative if they just said what the files are, e.g.
| obj # Windows, MSVC object files
| pch # Windows, MSVC precompiled headers
khwilliamson
force-pushed
the
podcheck_t_ignore_MSVC_infrastructure
branch
from
7732c2a
to
c59efa4
Compare
|
This looks pretty reasonable to me as well, but we are getting
which I suspect is coincidental |
-Don't open binary build products and binary C debugger related disk files these can't be parsed for POD, or are access-denied locked disk files for paused processes in C debuggers. Users shouldn't exit open IDE windows and open C debugger windows, just to make podcheck.t pass. -.def is ascii but auto-gened and not Perl grammar
bulk88
force-pushed
the
podcheck_t_ignore_MSVC_infrastructure
branch
from
c59efa4
to
8f3d461
Compare
|
revised/expanded, saw podcheck.t reading more types of binaries off disk that it shouldn't and can't contain POD |
|
Looking good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Don't open binary build products and binary C debugger related disk files
these can't be parsed for POD, or are access-denied locked disk files for
paused processes in C debuggers. Users shouldn't exit open IDE windows
and open C debugger windows, just to make podcheck.t pass.
Don't think it does. Its too perl core dev specific.