Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm64 darwin hints when using use64bitall with Configure #22672

Merged
merged 3 commits into from
Oct 26, 2024

Commits on Oct 16, 2024

  1. Fix darwin arch hint on arm64 when using use64bitall

    When calling Configure with use64bitall on arm64 macOS, it compiles a test program using clang and an -arch flag that is not followed by anything. Seems like the darwin arch hint when using use64bitall couldn't work with the 'arm' result from uname -p.
    mtsanovv committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    796f85d View commit details
    Browse the repository at this point in the history
  2. Exit on unrecognized darwin arch hint

    Not sure if Apple are to introduce another CPU architecture to their device lineup - but they already did it 2 times. When building this on arm64 macOS, before adding the arm64 arch hint, Configure with use64bitall wouldn't exit, but a rather cryptic clang error would be thrown for an unknown arch name, simply because nothing was passed after the -arch flag.
    mtsanovv committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4efa26a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Fix failing AUTHORS test

    mtsanovv committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    3df005c View commit details
    Browse the repository at this point in the history