-
Notifications
You must be signed in to change notification settings - Fork 222
Demo: Resource estimation: Hamiltonian Simulation with GQSP #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Your preview is ready 🎉!You can view your changes here
|
daniela-angulo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo is very clear. The message is conveyed smoothly!
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniela Angulo <[email protected]>
Jaybsoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whole bunch of formatting and correctness changes
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
AntonNI8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is shaping up very nicely 🚀
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/metadata.json
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/metadata.json
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/metadata.json
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/metadata.json
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
demonstrations_v2/tutorial_estimator_hamiltonian_simulation_gqsp/demo.py
Outdated
Show resolved
Hide resolved
| # standard state preparation algorithm called `QROMStatePreparation <https://docs.pennylane.ai/en/stable/code/api/pennylane.estimator.templates.QROMStatePreparation.html>`_, | ||
| # based on `QROM <https://pennylane.ai/qml/demos/tutorial_intro_qrom>`_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that it is best practice to link functions/classes using
:func:`this func` and :class:`this class` etc.and other demos via
:doc:`QROM <tutorial_intro_qrom>`This makes the links more resilient to URL changes since we are not encoding the base URL, and also the CI will give us warnings when links are broken.
(comment applies throughout the demo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Josh! I replaced the demo links according to this best practice.
For some of the links to the classes in estimator, we are unable to use the standard syntax because of some of the sphinx changes that were made to allow for multiple Classes of the same name (qml.QROM vs. qre.QROM). I tried a few variations but the only thing that worked were these direct links.
|
Hi! Just letting everyone know in case it happens in the future, the reference gqsp wasn't working because there is a variable in the code with the same name. I changed the reference to gqsp2024 and looks good now. |
Jaybsoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Before submitting
Please complete the following checklist when submitting a PR:
Ensure that your tutorial executes correctly, and conforms to the
guidelines specified in the README.
Remember to do a grammar check of the content you include.
All tutorials conform to
PEP8 standards.
To auto format files, simply
pip install black, and thenrun
black -l 100 path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Title: Resource estimation for Hamiltonian simulation with GQSP
(more details here)