Skip to content

Conversation

@ixfoduap
Copy link
Contributor

@ixfoduap ixfoduap commented Dec 8, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • Ensure that your tutorial executes correctly, and conforms to the
    guidelines specified in the README.

  • Remember to do a grammar check of the content you include.

  • All tutorials conform to
    PEP8 standards.
    To auto format files, simply pip install black, and then
    run black -l 100 path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Title: Resource estimation for Hamiltonian simulation with GQSP

  • Which of the following types of documentation is most similar to your file?
    (more details here)
  • Tutorial
  • Demo
  • How-to

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Your preview is ready 🎉!

You can view your changes here

Deployed at: 2026-01-29 19:44:10 UTC

@Jaybsoni Jaybsoni changed the base branch from master to dev January 5, 2026 22:22
@Jaybsoni Jaybsoni requested a review from josh146 January 8, 2026 23:00
Copy link
Contributor

@daniela-angulo daniela-angulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo is very clear. The message is conveyed smoothly!

@Jaybsoni Jaybsoni requested review from a team as code owners January 21, 2026 21:18
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A whole bunch of formatting and correctness changes

@Jaybsoni Jaybsoni self-requested a review January 22, 2026 20:06
Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is shaping up very nicely 🚀

Comment on lines 88 to 89
# standard state preparation algorithm called `QROMStatePreparation <https://docs.pennylane.ai/en/stable/code/api/pennylane.estimator.templates.QROMStatePreparation.html>`_,
# based on `QROM <https://pennylane.ai/qml/demos/tutorial_intro_qrom>`_,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that it is best practice to link functions/classes using

:func:`this func` and :class:`this class` etc.

and other demos via

:doc:`QROM <tutorial_intro_qrom>`

This makes the links more resilient to URL changes since we are not encoding the base URL, and also the CI will give us warnings when links are broken.

(comment applies throughout the demo)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Josh! I replaced the demo links according to this best practice.

For some of the links to the classes in estimator, we are unable to use the standard syntax because of some of the sphinx changes that were made to allow for multiple Classes of the same name (qml.QROM vs. qre.QROM). I tried a few variations but the only thing that worked were these direct links.

@daniela-angulo
Copy link
Contributor

daniela-angulo commented Jan 27, 2026

Hi! Just letting everyone know in case it happens in the future, the reference gqsp wasn't working because there is a variable in the code with the same name. I changed the reference to gqsp2024 and looks good now.

@Jaybsoni Jaybsoni requested a review from AntonNI8 January 29, 2026 18:37
@Jaybsoni Jaybsoni requested a review from josh146 January 29, 2026 19:01
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants