chore: fix function name in comment #326
Conversation
Signed-off-by: pinglanlu <[email protected]>
WalkthroughThe changes involve renaming two RPC methods in the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🔇 Additional comments (8)proto/cork/v2/query.proto (1)
Let's verify the existing usage patterns to ensure a smooth transition to the new endpoints. ✅ Verification successfulNo breaking changes detected in query endpoints The verification shows these endpoints are properly implemented and tested:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for existing client implementations and usages
rg -l "QueryScheduledCorks" --type rust --type go
# Search for any existing tests using these endpoints
rg -l "scheduled_corks" --type rust --type go --glob "*test*"
Length of output: 714 Script: #!/bin/bash
# Let's check the specific implementations and usages of these endpoints
rg "QueryScheduledCorksByBlockHeight|QueryScheduledCorksByID" -A 5 x/cork/keeper/query_server.go x/cork/client/cli/query.go
# Check test implementations
rg "QueryScheduledCorksByBlockHeight|QueryScheduledCorksByID" integration_tests/scheduled_cork_test.go x/cork/keeper/query_server_test.go x/cork/client/cli/query_test.go
# Check if these are new additions by looking at git history
git log -p -- proto/cork/v2/query.proto | grep -A 5 "QueryScheduledCorksByBlockHeight\|QueryScheduledCorksByID"
Length of output: 6448 proto/axelarcork/v1/query.proto (4)
The new HTTP routes follow the established pattern and REST conventions, using path parameters appropriately. Also applies to: 50-50 Line range hint The new message types
The REST endpoint Let's check for parameter validation in the implementation: #!/bin/bash
# Search for the handler implementation
ast-grep --pattern 'func $_(QueryScheduledCorksByBlockHeightRequest) $_ {
$$$
}'
While the new methods
Let's verify the usage of these methods across the codebase: Consider one of these approaches:
Also applies to: 47-51 somm_proto/src/prost/cork.v2.rs (2)Line range hint The method has been correctly renamed to Line range hint The method has been correctly renamed to somm_proto/src/prost/axelarcork.v1.rs (1)Line range hint The implementation follows the standard tonic gRPC client patterns with proper error handling and path configuration. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closes: #XXX
Description
fix function name in comment
Summary by CodeRabbit
New Features
Documentation