[cdc] don't cache replident during cdc #2140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Oct 16, 2024
| @@ -167,6 +167,8 @@ message CreateRawTableOutput { string table_identifier = 1; } | |||
| message TableSchema { | |||
| string table_identifier = 1; | |||
| repeated string primary_key_columns = 2; | |||
| // only used during SetupFlow, CDC fetches it everytime | |||
| // TODO: rename at some point | |||
There was a problem hiding this comment.
can this be cleared out as migration so in future it can be removed? Could otherwise mark deprecated
There was a problem hiding this comment.
prefer not to remove it because I want entirety of SetupFlow to use the same value
want to just rename it to make sure it's not used elsewhere
There was a problem hiding this comment.
Can create model
type SetupTableSchema {
*protos.TableSchema
...rest
}
& pass that around instead of the proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replident can be changed anytime, caching during CDC shouldn't be done
since we store TableSchema in catalog not removing
is_replica_identity_fullfor now