Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace clickhouse-go with ch-go #2134

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

replace clickhouse-go with ch-go #2134

wants to merge 4 commits into from

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Oct 11, 2024

not really used on any hot path so don't expect perf gains yet, but opens up better batch inserting based on discussion with @gingerwizard

@serprex serprex marked this pull request as draft October 11, 2024 20:27
@serprex serprex force-pushed the chgo branch 3 times, most recently from d518ccb to 8297d83 Compare October 11, 2024 21:07
@serprex
Copy link
Contributor Author

serprex commented Oct 12, 2024

for io.EOF retries we'll need to reconnect by recreating client

@serprex
Copy link
Contributor Author

serprex commented Oct 13, 2024

Looks like ColAuto is quite incomplete, started work on making it more complete upstream: ClickHouse/ch-go#433

Also need to fix up decimal support, see ClickHouse/ch-go#128 (ClickHouse/ch-go#434)

@serprex
Copy link
Contributor Author

serprex commented Oct 17, 2024

using branch for better inference gets further in tests, but then needs ClickHouse/ch-go#435 will update again once one of my 2 open PRs to ch-go merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant