Initial changes for KEDA - Pod Autoscaling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robkooper
reviewed
Nov 16, 2022
| ## KEDA RabbitMQ Configuration | ||
| ## ------------------------------------------------------------------------------- | ||
|
|
||
| keda: |
There was a problem hiding this comment.
can we add an enabled here (default false), so we can use that to add the keda pieces.
robkooper
reviewed
Nov 16, 2022
| name: "rabbitmq" | ||
| ## Base64 rabbitmq host path in the form of PROTOCOL://<RABBITMQ_USER>:RABBITMQ_PASSWORD@RABBITMQ_HOST/vhost | ||
| ## e.g. echo -n 'http://guest:[email protected]:15672//' | base64 | ||
| host: aHR0cDovL2d1ZXN0Omd1ZXN0QHBlY2FuLXJhYmJpdG1xLmRlZmF1bHQ6MTU2NzIvLw== |
There was a problem hiding this comment.
instead of hardcoding it in the url, can we compute this in the secret?
robkooper
requested changes
Nov 16, 2022
| metadata: | ||
| name: {{ .Values.keda.rabbitmq.name }}-secret | ||
| data: | ||
| host: {{ .Values.keda.rabbitmq.host }} # base64 encoded value of connection string |
There was a problem hiding this comment.
i think we can use:
{{ include "pecan.rabbitmq" . | b64enc }}
| @@ -0,0 +1,31 @@ | |||
| {{- if .Values.models }} | |||
There was a problem hiding this comment.
if we add a {{ if .Values.keda.enabled }} then we can disable this and only add these resources if they have keda installed. Otherwise we are forcing keda to be installed.
| @@ -9,7 +9,10 @@ Climate change science has witnessed an explosion in the amount and types of dat | |||
| ```bash | |||
| $ helm repo add ncsa https://opensource.ncsa.illinois.edu/charts/ | |||
| $ helm repo add bitnami https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami | |||
| $ helm repo add kedacore https://kedacore.github.io/charts | |||
There was a problem hiding this comment.
maybe we create a subsection and for auto-scaling. And explain that for this to work they need to install keda first, and enable it in the pecan helm chart as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.