Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoA Network support #9

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

youtweakit
Copy link

@youtweakit youtweakit commented Jan 8, 2018

ETH-Hot-Wallet

Thank you for contributing!

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the [MIT License].

PaulLaux and others added 2 commits December 24, 2017 08:59
v0.3.0 and Saving encrypted keystore to Local storage
Copy link
Owner

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change Infura keys for Ropsten Testnet and Main Net?

@youtweakit
Copy link
Author

I've copied my infura keys from another project. Is it important to keep
any of them? )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants