This repository has been archived by the owner on Feb 4, 2019. It is now read-only.
Support for "finally" clauses #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -424,11 +424,20 @@ private StatementAst BuildBreakStatementAst(ParseTreeNode parseTreeNode) | |||
|
|
|||
| StatementAst BuildTryStatementAst(ParseTreeNode parseTreeNode) | |||
| { | |||
| var subClauses = parseTreeNode.ChildNodes[0].ChildNodes; | |||
| var catchClauses = subClauses[2]; | |||
There was a problem hiding this comment.
Won't this be incorrect on multiple catch blocks?
Ref: http://stackoverflow.com/questions/8381237/powershell-catching-typed-exceptions#8381798
There was a problem hiding this comment.
According to the grammar, the 3rd element of the specific parseTree is either a "finally_clause" or "catch_clauses" sub tree. The latter one has multiple childs representing multiple cacth clauses.
The following functions care about finding the concrete catch clauses in the "sub tree".
However, multiple catch clauses are not yet evaluated correctly, see #414.
|
Any further comments or may this get merged? |
|
Looks good to me. My vote for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finallyclauses are now correctly parsed and executed.Fixes #411.