Handle sending and receiving metrics messages #2623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lailabougria
approved these changes
Nov 25, 2024
fix approval tests cleanup usings exclude tests that fail due to lack of binary serialization support Move metrics message tests Create a transport test permutation to test unwrapped messages Add transport tests Handle outgoing and incoming metrics messages Add constants for metrics-related message
lailabougria
force-pushed
the
handle-sending-receiving-metrics-messages
branch
from
0a3f95d to
9945f5f
Compare
ramonsmits
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Fix testrun issue fix approval tests cleanup usings exclude tests that fail due to lack of binary serialization support Move metrics message tests Create a transport test permutation to test unwrapped messages Add transport tests Handle outgoing and incoming metrics messages Add constants for metrics-related message * update references --------- Co-authored-by: Laila Bougria <[email protected]>
lailabougria
added a commit
that referenced
this pull request
Nov 27, 2024
* Fix testrun issue fix approval tests cleanup usings exclude tests that fail due to lack of binary serialization support Move metrics message tests Create a transport test permutation to test unwrapped messages Add transport tests Handle outgoing and incoming metrics messages Add constants for metrics-related message * update references --------- Co-authored-by: Laila Bougria <[email protected]> (cherry picked from commit 205b450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
DoNotWrapOutgoingMessagesset to true cannot be used with NServiceBus.Metrics.ServiceControl #2520