Convert major powers with at least 300 territories to empires (#1464)

ParadoxGameConverters · Aug 6, 2023 · aae538d · aae538d
1 parent fd1aa7e
commit aae538d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 18 deletions.
diff --git a/ImperatorToCK3/Imperator/Countries/Country.cs b/ImperatorToCK3/Imperator/Countries/Country.cs
@@ -60,25 +60,17 @@ public SortedSet<string> GetLaws() {
 			_ => monarchyLaws,
 		};
 	}
+	public int TerritoriesCount => ownedProvinces.Count;
 	public CountryRank Rank {
 		get {
-			var provCount = ownedProvinces.Count;
-			if (provCount == 0) {
-				return CountryRank.migrantHorde;
-			}
-			if (provCount == 1) {
-				return CountryRank.cityState;
-			}
-			if (provCount <= 24) {
-				return CountryRank.localPower;
-			}
-			if (provCount <= 99) {
-				return CountryRank.regionalPower;
-			}
-			if (provCount <= 499) {
-				return CountryRank.majorPower;
-			}
-			return CountryRank.greatPower;
+			return TerritoriesCount switch {
+				0 => CountryRank.migrantHorde,
+				1 => CountryRank.cityState,
+				<= 24 => CountryRank.localPower,
+				<= 99 => CountryRank.regionalPower,
+				<= 499 => CountryRank.majorPower,
+				_ => CountryRank.greatPower
+			};
 		}
 	}
 	public void RegisterProvince(Province province) {

diff --git a/ImperatorToCK3/Mappers/TagTitle/TagTitleMapper.cs b/ImperatorToCK3/Mappers/TagTitle/TagTitleMapper.cs
@@ -161,7 +161,12 @@ private static string GetCK3TitleRank(Country country, string localizedTitleName
 		if (localizedTitleName.Contains("Kingdom", System.StringComparison.Ordinal)) {
 			return "k";
 		}
-
+
+		// Major power rank is very broad (from 100 to 499 territories). Consider 300+ territories as empire material.
+		if (country is {Rank: CountryRank.majorPower, TerritoriesCount: >= 300}) {
+			return "e";
+		}
+
 		switch (country.Rank) {
 			case CountryRank.migrantHorde:
 			case CountryRank.cityState: