Speed up OnFrameworkInitializationCompleted, remove some async void u…

…sage (#763)

* Run debug info logging and startup update check in separate threads

* Convert CheckForUpdates from async void to async Task

Fronter.NET/App.axaml.cs

@@ -10,6 +10,7 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;
+using System.Threading.Tasks;
 
 namespace Fronter;
 
@@ -23,7 +24,7 @@ public override void Initialize() {
 
 		AvaloniaXamlLoader.Load(this);
 
-		LoadTheme();
+		_ = Task.Run(LoadTheme);
 	}
 
 	public override void OnFrameworkInitializationCompleted() {
@@ -34,14 +35,14 @@ public override void OnFrameworkInitializationCompleted() {
 			var mainWindowViewModel = new MainWindowViewModel(window.FindControl<DataGrid>("LogGrid")!);
 			window.DataContext = mainWindowViewModel;
 
-			desktop.MainWindow.Opened += (sender, args) => DebugInfo.LogEverything();
-			desktop.MainWindow.Opened += (sender, args) => mainWindowViewModel.CheckForUpdatesOnStartup();
+			desktop.MainWindow.Opened += (sender, args) => _ = Task.Run(DebugInfo.LogEverything);
+			desktop.MainWindow.Opened += (sender, args) => _ = mainWindowViewModel.CheckForUpdatesOnStartup();
 		}
 
 		base.OnFrameworkInitializationCompleted();
 	}
 
-	private static async void LoadTheme() {
+	private static async Task LoadTheme() {
 		if (!File.Exists(FronterThemePath)) {
 			SetTheme(DefaultTheme);
 			return;
@@ -85,7 +86,7 @@ public static void SetTheme(string themeName) {
 	/// Sets and saves a theme
 	/// </summary>
 	/// <param name="themeName" >Name of the theme to set and save.</param>
-	public static async void SaveTheme(string themeName) {
+	public static async Task SaveTheme(string themeName) {
 		SetTheme(themeName);
 		try {
 			await using var fs = new FileStream(FronterThemePath, FileMode.Create, FileAccess.Write, FileShare.ReadWrite);

Fronter.NET/Fronter.csproj

@@ -79,7 +79,7 @@
         <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.1" />
         <PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
         <PackageReference Include="Notification.Avalonia" Version="2.1.0" />
-        <PackageReference Include="PGCG.commonItems" Version="15.1.4" />
+        <PackageReference Include="PGCG.commonItems" Version="15.1.5" />
         <PackageReference Include="Roslynator.Analyzers" Version="4.12.10">
           <PrivateAssets>all</PrivateAssets>
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Fronter.NET/ViewModels/MainWindowViewModel.cs

@@ -184,7 +184,7 @@ private void CopyToTargetGameModDirectory() {
 		});
 		copyThread.Start();
 	}
-	public void LaunchConverter() {
+	public async Task LaunchConverter() {
 		ConvertButtonEnabled = false;
 		ClearLogGrid();
 
@@ -201,7 +201,7 @@ public void LaunchConverter() {
 
 		var converterLauncher = new ConverterLauncher(Config);
 		bool success;
-		var converterThread = new Thread(() => {
+		await Task.Run(async () => {
 			ConvertStatus = "CONVERTSTATUSIN";
 
 			try {
@@ -245,14 +245,13 @@ public void LaunchConverter() {
 				}
 			} else {
 				ConvertStatus = "CONVERTSTATUSPOSTFAIL";
-				Dispatcher.UIThread.Post(ShowErrorMessageBox);
+				await Dispatcher.UIThread.InvokeAsync(ShowErrorMessageBox);
 				ConvertButtonEnabled = true;
 			}
 		});
-		converterThread.Start();
 	}
 
-	private async void ShowErrorMessageBox() {
+	private async Task ShowErrorMessageBox() {
 		var messageBoxWindow = MessageBoxManager
 			.GetMessageBoxStandard(new MessageBoxStandardParams {
 				Icon = Icon.Error,
@@ -267,7 +266,7 @@ private async void ShowErrorMessageBox() {
 		}
 	}
 
-	public async void CheckForUpdates() {
+	public async Task CheckForUpdates() {
 		if (!Config.UpdateCheckerEnabled) {
 			return;
 		}
@@ -319,11 +318,11 @@ await Dispatcher.UIThread.InvokeAsync(async () => {
 		}
 	}
 
-	public void CheckForUpdatesOnStartup() {
+	public async Task CheckForUpdatesOnStartup() {
 		if (!Config.CheckForUpdatesOnStartup) {
 			return;
 		}
-		CheckForUpdates();
+		await CheckForUpdates();
 	}
 
 #pragma warning disable CA1822
@@ -335,7 +334,7 @@ public void Exit() {
 	}
 
 #pragma warning disable CA1822
-	public async void OpenAboutDialog() {
+	public async Task OpenAboutDialog() {
 #pragma warning restore CA1822
 		var messageBoxWindow = MessageBoxManager
 			.GetMessageBoxStandard(new MessageBoxStandardParams {
@@ -365,7 +364,7 @@ public void SetLanguage(string languageKey) {
 #pragma warning disable CA1822
 	public void SetTheme(string themeName) {
 #pragma warning restore CA1822
-		App.SaveTheme(themeName);
+		_ = App.SaveTheme(themeName);
 	}
 
 	public string WindowTitle {

Fronter.NET/ViewModels/PathPickerViewModel.cs

@@ -23,8 +23,8 @@ public PathPickerViewModel(Config config) {
 		RequiredFiles = new ObservableCollection<RequiredFile>(config.RequiredFiles);
 
 		// Create reactive commands.
-		OpenFolderDialogCommand = ReactiveCommand.Create<RequiredFolder>(OpenFolderDialog);
-		OpenFileDialogCommand = ReactiveCommand.Create<RequiredFile>(OpenFileDialog);
+		OpenFolderDialogCommand = ReactiveCommand.CreateFromTask<RequiredFolder>(OpenFolderDialog);
+		OpenFileDialogCommand = ReactiveCommand.CreateFromTask<RequiredFile>(OpenFileDialog);
 	}
 
 	public ObservableCollection<RequiredFolder> RequiredFolders { get; }
@@ -63,7 +63,7 @@ public PathPickerViewModel(Config config) {
 	}
 
 	[SuppressMessage("ReSharper", "MemberCanBeMadeStatic.Global")]
-	public async void OpenFolderDialog(RequiredFolder folder) {
+	public async Task OpenFolderDialog(RequiredFolder folder) {
 		var storageProvider = MainWindow.Instance.StorageProvider;
 
 		var options = new FolderPickerOpenOptions {
@@ -88,7 +88,7 @@ public async void OpenFolderDialog(RequiredFolder folder) {
 	}
 
 	[SuppressMessage("ReSharper", "MemberCanBeMadeStatic.Global")]
-	public async void OpenFileDialog(RequiredFile file) {
+	public async Task OpenFileDialog(RequiredFile file) {
 		var storageProvider = MainWindow.Instance.StorageProvider;
 
 		var options = new FilePickerOpenOptions {