Code tweaks in TranslationSource class (#688)

ParadoxGameConverters · Nov 21, 2024 · 1a8e09a · 1a8e09a
1 parent 8bb24aa
commit 1a8e09a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/actions/build_frontend/entrypoint.sh b/.github/actions/build_frontend/entrypoint.sh
@@ -38,7 +38,7 @@ then
 
   if [ "$RUNNER_OS" = "macOS" ]
   then
-    brew uninstall packaging
+    brew uninstall python-packaging
   fi
 
   PIP_BREAK_SYSTEM_PACKAGES=1 pip3 install -r requirements.txt 

diff --git a/Fronter.NET/Extensions/TranslationSource.cs b/Fronter.NET/Extensions/TranslationSource.cs
@@ -28,7 +28,7 @@ private TranslationSource() {
 				cultureInfo = CultureInfo.GetCultureInfo(cultureName);
 			} catch (CultureNotFoundException) {
 				logger.Debug($"Culture {cultureName} for language {langKey} not found!");
-				if (langKey == "english") {
+				if (string.Equals(langKey, "english", StringComparison.OrdinalIgnoreCase)) {
 					cultureInfo = CultureInfo.InvariantCulture;
 				} else {
 					return;
@@ -95,7 +95,7 @@ private void LoadLanguages() {
 		var fileNames = SystemUtils.GetAllFilesInFolder("Configuration");
 
 		foreach (var fileName in fileNames) {
-			if (!fileName.EndsWith(".yml")) {
+			if (!fileName.EndsWith(".yml", StringComparison.OrdinalIgnoreCase)) {
 				continue;
 			}
 
@@ -148,9 +148,9 @@ private void LoadLanguages() {
 		}
 	}
 
-	public IList<string> LoadedLanguages { get; } = new List<string>();
-	private readonly Dictionary<string, CultureInfo> languages = new();
-	private readonly Dictionary<string, Dictionary<string, string>> translations = new(); // key, <language, text>
+	public IList<string> LoadedLanguages { get; } = [];
+	private readonly Dictionary<string, CultureInfo> languages = [];
+	private readonly Dictionary<string, Dictionary<string, string>> translations = []; // key, <language, text>
 
 	private string currentLanguage = "english";
 	public string CurrentLanguage {