Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated code warning #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mantas-2155X
Copy link

Fixes file:///usr/share/sddm/themes/materia-dark/Main.qml:31:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

@varlesh
Copy link
Contributor

varlesh commented May 22, 2022

It's can be compability on LTS distros with old Qt versions?
On Elarun not use this functions:
https://github.com/sddm/sddm/blob/develop/data/themes/elarun/Main.qml#L42

@Mantas-2155X
Copy link
Author

I believe this functionality was added with Qt 5.14 as seen here.

@Mantas-2155X
Copy link
Author

Kubuntu 22.04 LTS has Qt 5.15.3,
Kubuntu 20.04 LTS has Qt 5.12.8

so I guess it is not compatible on older LTS releases :(

@varlesh
Copy link
Contributor

varlesh commented May 22, 2022

Ok, thx! I think now it's can not be merged... but not close, for future

@varlesh varlesh mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants