Skip to content

Comments

Update for unpick v3/4 API#57

Merged
jpenilla merged 9 commits intomainfrom
unpick-v3-4
Oct 26, 2025
Merged

Update for unpick v3/4 API#57
jpenilla merged 9 commits intomainfrom
unpick-v3-4

Conversation

@jpenilla
Copy link
Member

test data:

unpick v3

group long chunk_ticket_type_expiration
	net.minecraft.server.level.TicketType.NO_TIMEOUT

group int chunk_ticket_type_flags
	@flags
	net.minecraft.server.level.TicketType.FLAG_PERSIST
	net.minecraft.server.level.TicketType.FLAG_LOADING
	net.minecraft.server.level.TicketType.FLAG_SIMULATION
	net.minecraft.server.level.TicketType.FLAG_KEEP_DIMENSION_ACTIVE
	net.minecraft.server.level.TicketType.FLAG_CAN_EXPIRE_IF_UNLOADED

target_method net.minecraft.server.level.TicketType register (Ljava/lang/String;JI)Lnet/minecraft/server/level/TicketType;
	param 1 chunk_ticket_type_expiration
	param 2 chunk_ticket_type_flags
target_method net.minecraft.server.level.TicketType <init> (JI)V
	param 0 chunk_ticket_type_expiration
	param 1 chunk_ticket_type_flags
target_method net.minecraft.server.level.TicketType timeout ()J
	return chunk_ticket_type_expiration
target_method net.minecraft.server.level.TicketType flags ()I
	return chunk_ticket_type_flags
Index: versions/25w43a/build.gradle.kts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/versions/25w43a/build.gradle.kts b/versions/25w43a/build.gradle.kts
--- a/versions/25w43a/build.gradle.kts	(revision 37fd67f93aba21ece1bfa0b55d404c2b02208356)
+++ b/versions/25w43a/build.gradle.kts	(date 1761343078345)
@@ -14,7 +14,7 @@
         "--remapper-file={remapperFile}",
         "--mappings-file={mappingsFile}",
         "--params-file={paramsFile}",
-        // "--constants-file={constantsFile}",
+        "--unpick-file={constantsFile}",
         "--output={output}",
         "--input={input}",
         "--input-classpath={inputClasspath}",
@@ -30,11 +30,16 @@
     remapperArgs.set(args)
 }
 
+repositories {
+    mavenLocal()
+}
+
 dependencies {
-    codebook("1.0.16")
+    codebook("1.0.17-SNAPSHOT")
     remapper(art("2.0.5"))
     decompiler(vineflower("1.11.1"))
     paramMappings("io.papermc.parchment.data:parchment:25w43a+build.1")
+    constants(files(file("./unpick.definitions")))
 }
 
 dependencies {

@jpenilla jpenilla marked this pull request as draft October 25, 2025 20:30
@jpenilla jpenilla marked this pull request as ready for review October 25, 2025 21:12
@jpenilla jpenilla merged commit c3ea69b into main Oct 26, 2025
2 checks passed
@jpenilla jpenilla deleted the unpick-v3-4 branch October 26, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant