Pass through packets in config phase #1459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
requested changes
Nov 15, 2024
| logger.error("Error forwarding known packs response to backend:", ex); | ||
| return null; | ||
| }); | ||
| if (player.getConnectionInFlight() != null) { |
There was a problem hiding this comment.
I think some aspects of this need reverting, the connection isn't always going to be inflight when we jump through configuration, but, events should still be fired, etc
There was a problem hiding this comment.
So that IF could just be moved in front of
player.getConnectionInFlight().ensureConnected().write(packet);
tho... it might affect plugins listening to config event?
There was a problem hiding this comment.
that would prevent plugins from being able to interact with reconfiguration while on a server, this block basically needs reverting
|
This is very good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds #1326 which got reverted by #1371
also adds pass through for the PluginMessagePacket