Do more speculative VarInt reading optimizations #1418
Merged
+124
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, I tweaked `MinecraftVarintFrameDecoder` a little bit, and added some logic to unroll the first iteration of `ProtocolUtils.readVarInt()` if we can. I haven't evaluated the performance of these changes.
The primary change was restricting the VarInt reads from the full 35-bit range to the truncated 21-bit range Minecraft uses for packet framing. As a result we can remove the five-byte VarInt special case. The unrolled 3-byte read would also be sufficient to read packets, but it doesn't hurt to try and squeeze out some extra performance.
jonesdevelopment
added a commit
to jonesdevelopment/sonar
that referenced
this pull request
Sep 6, 2024
jonesdevelopment
added a commit
to jonesdevelopment/NanoLimbo
that referenced
this pull request
Sep 21, 2024
BluSpring
pushed a commit
to CrunchMunchCreations/NanoLimbo
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, I tweaked
MinecraftVarintFrameDecodera little bit, and added some logic to unroll the first iteration ofProtocolUtils.readVarInt()if we can.I haven't evaluated the performance of these changes.