-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SCHEMA_TYPE to distinguish request/response to support readOnly/writeOnly properties #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riteOnly properties
Size Change: +20.5 kB (0%) Total Size: 5.99 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 6a82262): https://docusaurus-openapi-36b86--pr665-q0x5k0ah.web.app (expires Fri, 29 Dec 2023 16:32:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
added a commit
that referenced
this pull request
Dec 1, 2023
* add negative look behind to exclude colon delimited path segments (#663) * use SCHEMA_TYPE to distinguish request/response to support readOnly/writeOnly properties (#665) * Improve support for handling multipart form data (#666) * use pdfblock to test multipart form data * switch back to cors proxy * add handler for generic key-value payload * debug response content type * refactor to download media and file content types * switch back to petstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When schema functions were collapsed into
createSchema
in #582 maintaining support forreadOnly
andwriteOnly
properties was overlooked. This PR adds aSCHEMA_TYPE
prop tocreateNodes
so that we can distinguish between "request" vs "response" schemas in order to handlereadOnly
andwriteOnly
appropriately.Motivation and Context
See #664
How Has This Been Tested?
Tested with petstore API. See deploy preview for live example.