-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:Removed no of batch and vulnerability shipper #2261
base: master
Are you sure you want to change the base?
Conversation
WalkthroughIn the Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- jobs/job-scheduler/src/main/java/com/paladincloud/jobscheduler/service/JobScheduler.java (2 hunks)
Additional comments not posted (1)
jobs/job-scheduler/src/main/java/com/paladincloud/jobscheduler/service/JobScheduler.java (1)
237-237
: The methodschedulePluginShipperJobs
appears to have been modified to adjust the scheduling logic. Ensure that the removal of the vulnerability shipper and other changes do not affect dependent systems or scheduled tasks negatively.#!/bin/bash # Description: Verify that the removal of the vulnerability shipper does not affect other systems. # Test: Search for any references to `schedulePluginShipperJobs` in other parts of the codebase. rg --type java 'schedulePluginShipperJobs'
Quality Gate passedIssues Measures |
Pr merged in release |
Description
Removed number of batch and vulnerability shipper
Problem
Solution
Fixes # (issue if any)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki
Summary by CodeRabbit
noOfBatches
field, streamlining theschedulePluginShipperJobs
method for better performance and maintainability.