feat:[CORE-2017]Adding additional Columns for Violation List View Filter #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AnandPaladin
requested review from
plyubich,
akashpaladin,
santhosh-challa and
ershad-paladin
Comment on lines
+3122
to
+3124
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (1,'Exemption Reason','reason-to-exempt.keyword','/compliance/v1/filters/attribute?ag=aws&attribute=reason-to-exempt&type=issue'); | ||
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (1,'ExemptionStatus ChangedOn','exemption-status-change.keyword','/compliance/v1/filters/attribute?ag=aws&attribute=exemption-status-change&type=issue'); | ||
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (1,'Exemption ExpiryDate','exemption-expiry-date.keyword','/compliance/v1/filters/attribute?ag=aws&attribute=exemption-expiry-date&type=issue'); |
There was a problem hiding this comment.
I see ?ag=aws in url. I hope this will work for all asset groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issues. Please also include relevant motivation and context. List
any dependencies that are required for this change.
Problem
Solution
Fixes # (issue if any)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Made DB changes at SAASDEV and tested API by running compliance API from local .Below are test results which have additional 3 columns expected
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki