Fix/infinite login loop issue 1737 (#1775)

* Fix : Infinite login page redirect loop

Bug: On webapp load, if config is missing, app can go into an infinite login page redirect loop #1737

* Delete error.component.spec.ts

No need for static error page

webapp/src/app/app.module.ts

@@ -33,9 +33,10 @@ import { LandingPageModule } from './landing-page/landing-page.module';
 import { FetchResourcesService } from './pacman-features/services/fetch-resources.service';
 import { PostLoginAppModule } from './post-login-app/post-login-app.module';
 import { TokenResolverService } from './resolver/token-resolver.service';
+import { ErrorComponent } from './error/error.component';
 
 @NgModule({
-    declarations: [AppComponent],
+    declarations: [AppComponent, ErrorComponent],
     imports: [
         BrowserModule,
         BrowserAnimationsModule,

webapp/src/app/error/error.component.css

@@ -0,0 +1,20 @@
+.error-container {
+    display: flex;
+    flex-direction: column;
+    align-items: center;
+    justify-content: center;
+    height: 100vh; /* 100% of the viewport height */
+    text-align: center;
+  }
+
+  h1 {
+    font-size: 36px;
+    color: #FF0000;
+    margin-bottom: 20px;
+  }
+
+  p {
+    font-size: 18px;
+    color: #333;
+  }
+

webapp/src/app/error/error.component.html

@@ -0,0 +1,4 @@
+<div class="error-container">
+    <h1>Something went wrong</h1>
+    <p>Please try again after some time.</p>
+</div>

webapp/src/app/error/error.component.ts

@@ -0,0 +1,15 @@
+import { Component, OnInit } from '@angular/core';
+
+@Component({
+  selector: 'app-error',
+  templateUrl: './error.component.html',
+  styleUrls: ['./error.component.css']
+})
+export class ErrorComponent implements OnInit {
+
+  constructor() { }
+
+  ngOnInit(): void {
+  }
+
+}

webapp/src/app/landing-page/landing-page.routing.module.ts

@@ -21,6 +21,7 @@ import { TokenResolverService } from '../resolver/token-resolver.service';
 
 import { HomePageComponent } from './home-page/home-page.component';
 import { LoginComponent } from './login/login.component';
+import { ErrorComponent } from '../error/error.component';
 
 const routes: Routes = [
     {
@@ -46,6 +47,10 @@ const routes: Routes = [
         redirectTo: '/home/login',
         pathMatch: 'full'
     },
+    {
+        path: 'error',
+        component: ErrorComponent,
+    },
 ];
 
 @NgModule({

webapp/src/app/landing-page/login/login.component.ts

@@ -58,9 +58,33 @@ export class LoginComponent implements OnInit {
         private cognitoService: AwsCognitoService,
         private httpService: HttpService,
         private dataCacheService:DataCacheService,
-        ) {
+        ) {}
 
-        console.log('Auth type:', CONFIGURATIONS.optional.auth.AUTH_TYPE)
+    @Input() menuState: string;
+    @Output() onClose = new EventEmitter();
+
+    ngOnInit() {
+        // Check if the configuration is valid; if not, navigate to the error page
+
+        if(this._verifyConfiguration()) this._init();
+        else this.router.navigate(['/error']);
+    }
+
+    private _verifyConfiguration(){
+        if(!CONFIGURATIONS.optional.auth.AUTH_TYPE){
+            console.error('AUTH_TYPE is missing in configuration');
+            return false
+        }
+        if(!CONFIGURATIONS.optional.auth.cognitoConfig.loginURL){
+            console.error('Login URL is missing in configuration');
+            return false
+        }
+        return true;
+    }
+    private _init(){
+        // Private method to initialize the application based on the configuration
+
+        console.log('Auth type:', CONFIGURATIONS.optional.auth.AUTH_TYPE);
         if (CONFIGURATIONS.optional.auth.AUTH_TYPE === 'azuresso') {
             this.adalService.login();
         } else if (CONFIGURATIONS.optional.auth.AUTH_TYPE === 'cognito') {
@@ -69,14 +93,7 @@ export class LoginComponent implements OnInit {
         } else {
             this.showOnPremLogin = true;
         }
-
-                    this.content = CONTENT;
-    }
-
-    @Input() menuState: string;
-    @Output() onClose = new EventEmitter();
-
-    ngOnInit() {
+        this.content = CONTENT;
     }
 
     login() {