Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PPSCI Doc No.10、11、30】 #724

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

MayYouBeProsperous
Copy link
Contributor

@MayYouBeProsperous MayYouBeProsperous commented Dec 27, 2023

PR types

Others

PR changes

Others

Describe

refine comments of ppsci.data.dataset.MeshAirfoilDataset, ppsci.data.dataset.MeshCylinderDataset, ppsci.arch.UNetEx, ppsci.arch.CFDGCN .

…dataset.MeshCylinderDataset, ppsci.arch.UNetEx, ppsci.arch.CFDGCN
Copy link

paddle-bot bot commented Dec 27, 2023

Thanks for your contribution!

... batch_norm=False,
... activation=None,
... final_activation=None,
... )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否可以构造一个input_dict,然后输入到该model里,然后得到output_dict,再打印output_dict["output"]呢?上面那个CFDGCN不太方便加这个测试,但是UNetEx应该可以吧

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果可以的话形状可以用128x128或者64x64啥的,不用太大否则有的机器测试都跑不了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,UNetEx 增加测试。output_dict["output"] 需要打印对比吗?数据比较多。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,UNetEx 增加测试。output_dict["output"] 需要打印对比吗?数据比较多。

不用,只需要打印并校验输出数据的形状即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit b8cb284 into PaddlePaddle:develop Dec 29, 2023
3 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* refine comments of ppsci.data.dataset.MeshAirfoilDataset, ppsci.data.dataset.MeshCylinderDataset, ppsci.arch.UNetEx, ppsci.arch.CFDGCN

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants