-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PPSCI Doc No.10、11、30】 #724
【PPSCI Doc No.10、11、30】 #724
Conversation
…dataset.MeshCylinderDataset, ppsci.arch.UNetEx, ppsci.arch.CFDGCN
Thanks for your contribution! |
... batch_norm=False, | ||
... activation=None, | ||
... final_activation=None, | ||
... ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是否可以构造一个input_dict,然后输入到该model里,然后得到output_dict,再打印output_dict["output"]呢?上面那个CFDGCN不太方便加这个测试,但是UNetEx应该可以吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果可以的话形状可以用128x128或者64x64啥的,不用太大否则有的机器测试都跑不了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,UNetEx 增加测试。output_dict["output"] 需要打印对比吗?数据比较多。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,UNetEx 增加测试。output_dict["output"] 需要打印对比吗?数据比较多。
不用,只需要打印并校验输出数据的形状即可
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refine comments of ppsci.data.dataset.MeshAirfoilDataset, ppsci.data.dataset.MeshCylinderDataset, ppsci.arch.UNetEx, ppsci.arch.CFDGCN * fix * fix
PR types
Others
PR changes
Others
Describe
refine comments of
ppsci.data.dataset.MeshAirfoilDataset
,ppsci.data.dataset.MeshCylinderDataset
,ppsci.arch.UNetEx
,ppsci.arch.CFDGCN
.