Conversation
There was a problem hiding this comment.
Pull request overview
本次 PR 主要更新 CI bypass 允许成员名单（CI_TEAM_MEMBERS），并移除一个自动更新 uv.lock 的 GitHub Actions workflow。
Changes:
- 从 CI bypass 允许名单中移除
ooooo-create - 同步更新 reusable workflow 与 composite action 中的
CI_TEAM_MEMBERS - 删除
.github/workflows/update_dependencies.yml（原用于定时/手动更新uv.lock并自动提 PR）
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/update_dependencies.yml | 删除自动更新 uv.lock 的 workflow |
| .github/workflows/check-bypass.yml | 更新 CI_TEAM_MEMBERS 环境变量名单 |
| .github/actions/check-bypass/action.yml | 更新 composite action 内置的 CI_TEAM_MEMBERS 名单 |
| contents: read | ||
| env: | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef", "ooooo-create"]' | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef"]' |
There was a problem hiding this comment.
CI_TEAM_MEMBERS 的 JSON 数组字符串里在 "risemeup1" 后多了一个空格（"risemeup1" ,）。虽然 JSON 允许空白，但这里建议格式化为一致的 JSON（去掉多余空格），以避免后续被严格解析器/正则处理时出现意外，并与 .github/actions/check-bypass/action.yml 保持一致。
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef"]' | |
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1", "XieYunshen", "luotao1", "tianlef"]' |
| contents: read | ||
| env: | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef", "ooooo-create"]' | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef"]' |
There was a problem hiding this comment.
PR 标题/描述信息过于简单且不符合约定的 [CLASS]Title 格式（例如 [CI] Update CI_TEAM_MEMBERS），并且当前标题还包含引号。建议按约定调整标题，并在描述中补充“为什么要移除该成员/变更影响范围”等背景，便于后续追踪。
| contents: read | ||
| env: | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef", "ooooo-create"]' | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1" , "XieYunshen", "luotao1", "tianlef"]' |
There was a problem hiding this comment.
本 PR 除了更新 CI_TEAM_MEMBERS 之外，还删除了 .github/workflows/update_dependencies.yml（自动更新 uv.lock 的定时/手动 workflow）。这与当前 PR 标题/描述不一致；建议在 PR 描述中明确删除原因（例如迁移到其他机制、该流程不再需要等），并确认不会影响依赖更新/安全修复的自动化流程。
| name: Check Bypass | ||
| env: | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1", "XieYunshen", "luotao1", "tianlef", "ooooo-create"]' | ||
| CI_TEAM_MEMBERS: '["swgu98", "risemeup1", "XieYunshen", "luotao1", "tianlef"]' |
There was a problem hiding this comment.
CI_TEAM_MEMBERS 在可复用 workflow（.github/workflows/check-bypass.yml）和 composite action（本文件）里各维护了一份，容易出现漂移（当前两处格式已经不完全一致）。建议将名单提取为单一来源（例如仓库变量 vars.CI_TEAM_MEMBERS，或作为输入参数并在调用处统一传入），两边都引用同一个值以减少维护成本。
1 participant
update CI_TEAM_MEMBERS