Clean sequence_enumerate sequence_erase [fluid_ops] #68356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co63oc
requested review from
zhwesky2010,
wanghuancoder and
Aurelius84
as code owners
co63oc
changed the title
python/paddle/nn/functional/loss.py
Outdated
Comment on lines
576
to
596
| # remove some tokens from input and labels | ||
| if ignored_tokens is not None and len(ignored_tokens) > 0: | ||
| erased_input = helper.create_variable_for_type_inference(dtype="int64") | ||
| erased_label = helper.create_variable_for_type_inference(dtype="int64") | ||
|
|
||
| helper.append_op( | ||
| type="sequence_erase", | ||
| inputs={"X": [input]}, | ||
| outputs={"Out": [erased_input]}, | ||
| attrs={"tokens": ignored_tokens}, | ||
| ) | ||
| input = erased_input | ||
|
|
||
| helper.append_op( | ||
| type="sequence_erase", | ||
| inputs={"X": [label]}, | ||
| outputs={"Out": [erased_label]}, | ||
| attrs={"tokens": ignored_tokens}, | ||
| ) | ||
| label = erased_label | ||
|
|
There was a problem hiding this comment.
这里直接删怕是不合适。先改成：
if ignored_tokens is not None and len(ignored_tokens) > 0:
raise error
吧
wanghuancoder
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Others
Description
清理python中 sequence_enumerate sequence_erase 等调用