Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Parallel] add align_mode supporting #68354

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

zhangyuqin1998
Copy link
Contributor

@zhangyuqin1998 zhangyuqin1998 commented Sep 21, 2024

PR Category

Auto Parallel

PR Types

Others

Description

add align_mode supporting

Pcard-76459

Copy link

paddle-ci-bot bot commented Sep 30, 2024

Sorry to inform you that 34a9ca9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@@ -338,6 +338,10 @@ def reduce_gradients(self, parameter_list, hcg):
)
g_var.scale_(1.0 / sharding_nrank)
reduce_op = ReduceOp.SUM

if paddle.distributed.in_auto_parallel_align_mode():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样建议加一下NOTE注释

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 793650b into PaddlePaddle:develop Oct 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants