Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing] Add type annotations for python/paddle/incubate/distributed/utils/io/{dist_save,save_for_auto}.py #67679

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

megemini
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/incubate/distributed/utils/io/dist_save.py
  • python/paddle/incubate/distributed/utils/io/save_for_auto.py

这两个文件的示例代码写的很随意,可能需要全部 ignore

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Aug 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 23, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@@ -73,6 +98,7 @@ def save(state_dict, path, **configs):
.. code-block:: python

>>> # doctest: +SKIP('TODO: the error will be fix in the feature')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future……之后哪个 PR 顺手改一下吧

@luotao1 luotao1 merged commit 0b9c752 into PaddlePaddle:develop Aug 26, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants