【Infer Symbolic Shape No.200】[BUAA] Addgather_tree #67625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| // } | ||
| bool GatherTreeOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| const symbol::ShapeOrDataDimExprs &ids_shape = |
There was a problem hiding this comment.
命名不规范，ids_shape_or_data
| "The shape of Input(Parents) must be same with the " | ||
| "shape of Input(Ids).")); | ||
|
|
||
| infer_context->SetShapeOrDataForValue(op->result(0), ids_shape); |
There was a problem hiding this comment.
这里直接把operand value的shape和data数据都传出去了，一般data区的数据需要抛弃掉。麻烦取出shape数据然后重新构造一个shapeordata数据。
luotao1
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
#66444
添加gather_tree算子符号推导接口