Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing] 修复示例中的类型标注错误 #67618

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

megemini
Copy link
Contributor

PR Category

User Experience

PR Types

Bug fixes

Description

修复#65397 中所有检查出的错误。

关联 PR #65008 #65397

@SigureMo

Copy link

paddle-bot bot commented Aug 21, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@megemini megemini changed the title [Typing] 修复示例中的类型标注错误 [Typing all] 修复示例中的类型标注错误 Aug 21, 2024
@megemini
Copy link
Contributor Author

@SigureMo typing all 看来木有错误了 ~ 但是有 whl_error

标注任务结束之后,转为正常 CI 流程,理论上应该是 typing all 的方式为最好 ~ 目前看,存在两个障碍:

  • 上面提到的 whl_error
  • CI 默认 typing all 会不会太占 CI 资源?

有啥想法?

@paddle-bot paddle-bot bot added the contributor External developers label Aug 21, 2024
@megemini megemini changed the title [Typing all] 修复示例中的类型标注错误 [Typing] 修复示例中的类型标注错误 Aug 22, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 506d9e2 into PaddlePaddle:develop Aug 23, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants