[Typing][C-41, C-42][BUAA] Add type annotations for python/paddle/distributed/fleet/base/*
#67439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
risemeup1
previously approved these changes
Aug 15, 2024
|
@megemini 顺师傅再看下 |
megemini
reviewed
Aug 15, 2024
| self._gloo.barrier(comm_world) | ||
|
|
||
| def _all_gather(self, input, comm_world="worker"): | ||
| def _all_gather(self, input: Any, comm_world="worker") -> task: |
There was a problem hiding this comment.
comm_world 没有标注，另外，为什么返回 task ？ list[float]
| def _all_reduce(self, input, mode="sum", comm_world="worker"): | ||
| def _all_reduce( | ||
| self, input: Any, mode: str = "sum", comm_world: str = "worker" | ||
| ) -> task: |
There was a problem hiding this comment.
Suggested change
| ) -> task: | |
| ) -> npt.NDArray[Any]: |
There was a problem hiding this comment.
@Whsjrczr 这里没修改
另外，上面是 list[float]
| """ | ||
| return the heter device type that current heter worker is using | ||
| """ | ||
| if not self._role_is_generated: | ||
| self._generate_role() | ||
| return self._heter_trainer_device_type | ||
|
|
||
| def _get_stage_id(self): | ||
| def _get_stage_id(self) -> int | str: |
There was a problem hiding this comment.
Suggested change
| def _get_stage_id(self) -> int | str: | |
| def _get_stage_id(self) -> int: |
| """ | ||
| return stage id of current heter worker | ||
| """ | ||
| if not self._role_is_generated: | ||
| self._generate_role() | ||
| return self._stage_id | ||
|
|
||
| def _get_stage_trainers(self): | ||
| def _get_stage_trainers(self) -> list: |
There was a problem hiding this comment.
Suggested change
| def _get_stage_trainers(self) -> list: | |
| def _get_stage_trainers(self) -> list[int]: |
| """ | ||
| whether current process is worker of rank 0 | ||
| """ | ||
| if not self._role_is_generated: | ||
| self._generate_role() | ||
| return self._role == Role.WORKER and self._current_id == 0 | ||
|
|
||
| def _worker_index(self): | ||
| def _worker_index(self) -> int | str: |
There was a problem hiding this comment.
Suggested change
| def _worker_index(self) -> int | str: | |
| def _worker_index(self) -> int: |
| return self._dp_degree | ||
|
|
||
| def get_data_parallel_group(self): | ||
| def get_data_parallel_group(self) -> list[int]: |
There was a problem hiding this comment.
Suggested change
| def get_data_parallel_group(self) -> list[int]: | |
| def get_data_parallel_group(self) -> Group: |
| def get_check_parallel_group(self, sharding=False): | ||
| def get_check_parallel_group( | ||
| self, sharding: bool = False | ||
| ) -> list[int] | Group: |
There was a problem hiding this comment.
Suggested change
| ) -> list[int] | Group: | |
| ) -> Group: |
Comment on lines
574
to
576
| def create_fuse_group( | ||
| self, fused_strategy_list: list[int] | ||
| ) -> list[int] | int: |
There was a problem hiding this comment.
Suggested change
| def create_fuse_group( | |
| self, fused_strategy_list: list[int] | |
| ) -> list[int] | int: | |
| def create_fuse_group( | |
| self, fused_strategy_list: list[str] | |
| ) -> tuple[list[list[int]], list[Group]] | tuple[list[int], Group]: |
| return self._topo.get_rank_from_stage( | ||
| self.global_rank, pipe=stage_id, **kwargs | ||
| ) | ||
|
|
||
| # fuse comm group message | ||
| def get_dp_sep_parallel_group(self): | ||
| def get_dp_sep_parallel_group(self) -> list[int]: |
There was a problem hiding this comment.
Suggested change
| def get_dp_sep_parallel_group(self) -> list[int]: | |
| def get_dp_sep_parallel_group(self) -> Group: |
| self._check_sep_exist() | ||
| return self._dp_sep_comm_group | ||
|
|
||
| def get_pp_mp_parallel_group(self): | ||
| def get_pp_mp_parallel_group(self) -> list[int]: |
There was a problem hiding this comment.
Suggested change
| def get_pp_mp_parallel_group(self) -> list[int]: | |
| def get_pp_mp_parallel_group(self) -> Group: |
Whsjrczr
changed the title
python/paddle/distributed/fleet/base/python/paddle/distributed/fleet/base/*
megemini
reviewed
Aug 16, 2024
Co-authored-by: megemini <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
megemini
reviewed
Aug 19, 2024
|
|
||
| import numpy as np | ||
| import numpy.typing as npt |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini